Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: put .local-browsers into .gitignore #1464

Merged

Conversation

mxschmitt
Copy link
Member

Yep I feel bad for these small PRs. But from my point of view it's good to have it in the .gitignore e.g. if you test something with Playwright directly from source.

@pavelfeldman
Copy link
Member

What about the one in line 6?

@mxschmitt
Copy link
Member Author

What about the one in line 6?

missed it, good catch! On my machine I installed the browsers in packages/playwright/.local-browsers via packages/playwright.

Should I simply remove the / of the entry in line 6, so it will catch that scenario too?

@aslushnikov aslushnikov merged commit 93954fe into microsoft:master Mar 22, 2020
@mxschmitt mxschmitt deleted the bugfix/local-browsers-gitignore branch November 13, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants